aalok05 / CodeHub

A UWP GitHub Client
MIT License
177 stars 35 forks source link

Can't authorize the app #134

Open yuezhenglingluan opened 4 years ago

yuezhenglingluan commented 4 years ago

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x ] Bug report  
[ ] Feature request
[ ] Question

Current behavior

can't tap the Authorize button to authorize codehub to github

Expected behavior

I should be able to authorize the app and get into codehub

Steps to reproduce the behavior

login to your account

Environment

tested on 19023 and 15254

nerocui commented 4 years ago

It seems like GitHub is no longer supporting IE. OAuth in most UWP is powered by WebAuthenticationBroker which only use IE. So... Oh and Microsoft said that they have to plan to change that. OAuth is basically broken on all UWP. Unless you do it manually.

Here is the official Q&A https://social.msdn.microsoft.com/Forums/SECURITY/en-US/ff3631c1-9264-47d7-9906-107a0614cdd7/uwp-how-to-set-webauthenticationbroker-to-use-edge-instead-of-ie?forum=wpdevelop

yuezhenglingluan commented 4 years ago

It seems like GitHub is no longer supporting IE. OAuth in most UWP is powered by WebAuthenticationBroker which only use IE. So... Oh and Microsoft said that they have to plan to change that. OAuth is basically broken on all UWP. Unless you do it manually.

Here is the official Q&A https://social.msdn.microsoft.com/Forums/SECURITY/en-US/ff3631c1-9264-47d7-9906-107a0614cdd7/uwp-how-to-set-webauthenticationbroker-to-use-edge-instead-of-ie?forum=wpdevelop

Okay thanks, so how can I do this manually?

nerocui commented 4 years ago

It seems like GitHub is no longer supporting IE. OAuth in most UWP is powered by WebAuthenticationBroker which only use IE. So... Oh and Microsoft said that they have to plan to change that. OAuth is basically broken on all UWP. Unless you do it manually. Here is the official Q&A https://social.msdn.microsoft.com/Forums/SECURITY/en-US/ff3631c1-9264-47d7-9906-107a0614cdd7/uwp-how-to-set-webauthenticationbroker-to-use-edge-instead-of-ie?forum=wpdevelop

Okay thanks, so how can I do this manually?

If you are an end user, there is nothing you can do about this specific app. But this app's source code already get's around IE by implementing it's own Auth Broker with the EdgeAuth class library. I think it's just not yet in the store version.