search

aarddict / android

Aard Dictionary for Android
GNU General Public License v3.0
85 stars 43 forks source link

Add "Select and Copy text" and "Send text to..." features within articles #87

Closed zpuric closed 11 years ago

zpuric commented 11 years ago

It would be very useful to have "Select and Copy text" and "Send text to..." features within article in order to be possible to combine it with common dictionary/translation and eLearning applications (for example Fora Dictionary, Google Translate, AnkiDroid, AnyMemo...).

Best regards!

itkach commented 11 years ago

Standard text selection and actions work in Android 4.x. This is not available in Android 2.x. On Sep 14, 2013 2:56 AM, "zpuric" notifications@github.com wrote:

It would be very useful to have "Select and Copy text" and "Send text to..." features within article in order to be possible to combine it with common dictionary/translation and eLearning applications (for example Fora Dictionary, Google Translate, AnkiDroid, AnyMemo...).

Best regards!

— Reply to this email directly or view it on GitHubhttps://github.com/aarddict/android/issues/87 .

zpuric commented 11 years ago

Thank you for your prompt response. I checked it on my friend's phone with Android 4x and it works as expected.

hirntot commented 11 years ago

but that doesn´t help anyone who has a 2.x phone. that´s kind of discrimination ;-(

itkach commented 11 years ago

Your discrimination complaint is misplaced. Address it to Google.

hirntot commented 11 years ago

wht? Why? there are thousends of other programs which support "Select and copy", even on my phone. and you really want to make me believe, google doesn't support this option for 2.x ???

dliw commented 11 years ago

itkach is right, the search option he is using is only available 3.x up (may actually be 4.x up, I'm not that sure). For search support in Android 2.x you have to use a completely different approach, which means lot of effort for fewer devices. Apart from that it isn't very comfortable - IMO one of the reasons why newer androids got a new API.

What does that have to do with me? For a long time there was the general request to implement a intext search for aard. At this time I forked this repo and implemented it (using the older approach). Only some days later official support was added. (https://github.com/aarddict/android/issues/74)

As I had android 4.x at this time and everything worked well for me, I didn't bother to do a merge and pull request and simply deleted my clone.

Btw. android 2.x depreciation is only a matter of time, especially for security reasons it isn't recommended to stay with this old system.

itkach commented 11 years ago

wht? Why? there are thousends of other programs which support "Select and copy", even on my phone. and you really want to make me believe, google doesn't support this option for 2.x ???

Tone it down, will you? I don't owe you money.

Articles are displayed by WebView component. There's a way to enable ability to copy text for some pre-Android 3.0 devices using undocumented, deprecated, now removed emulateShiftHeld() method, as described, say, here. It looks like this is not available on Android 2.1 though (if I'm not mistaken, Nook Touch devices are stuck with it forever). It is also not clear whether this works on all 2.2 and 2.3 devices (Samsung, for example, ships their own flavor of WebView on Galaxy devices, as far as I can tell).

I myself am no longer using Android 2.x devices. I don't feel like doing the research, testing and hacking this in to work around Google's omission in ancient Android versions. I may consider a working, tested patch. Feel free to submit one.

hirntot commented 11 years ago

Hello to both of you!

well, finally I got two anwers I can believe and maybe work on it! Thank you for that. I will check the links later...

@itkach Tone seemed already to be down in your answer. But anyway, sorry for my tone. Finally your App is still the best, even on my Samsung (And2.3). (where the only maybe-alternative kiwix is not supportet any more)

yeah, I know, it is not the newest device. But I am not yet wasteful enough to waste a generally working phone. And I hope I will never be...

cheers