search

aarddict / android

Aard Dictionary for Android
GNU General Public License v3.0
85 stars 43 forks source link

Ignore trailing white space in entered lookup text #97

Closed rkern closed 10 years ago

rkern commented 10 years ago

Some keyboards, namely SwiftKey, will automatically add a space when you use the autocomplete. It would be great to not have to backspace every time before submitting the word.

itkach commented 10 years ago

Dictionary entries are not always one word, contain spaces, so space at the end is part of lookup just as any other character. Ignoring trailing space results in odd lookup results being displayed as you type lookup phrase containing spaces.

rkern commented 10 years ago

Can you walk me through some of the odd lookup results that you might get? Because the current behavior gives me odd and useless lookup results ~99% of the time I try to use the app.

itkach commented 10 years ago

Don't use it then. On Apr 26, 2014 1:30 PM, "Robert Kern" notifications@github.com wrote:

Can you walk me through some of the odd lookup results that you might get? Because the current behavior gives me odd and useless lookup results ~99% of the time I try to use the app.

— Reply to this email directly or view it on GitHubhttps://github.com/aarddict/android/issues/97#issuecomment-41474947 .

rkern commented 10 years ago

I would rather work up a pull request if we can come to an agreement on this issue. I am not complaining or begging for you to do work for me for free. I intended my "~99%" remark merely to precisely report a usability problem with the app as it stands and not to sound snarky and ungracious. I can see in retrospect how it could be read so. I apologize.

Changing the behavior may introduce another usability problem; you have alluded to one. I can believe that there is one, but I don't see one at this time. That's why I asked for more details. If we can put the two alternatives side by side, we might be able to come to an agreement on a possible change or even a third compromise alternative, and I will be happy to code it up.

Thank you.