aarongustafson / jekyll-webmention_io

A Jekyll Plugin for rendering Webmentions via Webmention.io
https://aarongustafson.github.io/jekyll-webmention_io/
MIT License
139 stars 27 forks source link

Fixing a bug by breaking a feature #168

Closed fancypantalons closed 1 year ago

fancypantalons commented 1 year ago

I don't understand the need to support sending webmentions for protocol-less links, and this code is busted: it results in the target hash table changing while we're in the middle of iterating over it (since the 'target' key value gets modified and a new has entry inserted).

If this is really needed we can always revisit later and refactor the code so it works.