aaronhuggins / node-x12

ASC X12 parser, generator, query engine, and mapper; now with support for streams.
https://aaronhuggins.github.io/node-x12/
MIT License
49 stars 14 forks source link

Fix edge case for element missing in document #26

Closed ahuggins-nhs closed 2 years ago

ahuggins-nhs commented 3 years ago
ahuggins-nhs commented 3 years ago

@Mohmedvaid may I include the EDI doc you provided as part of the test suite under the license for this library?

ahuggins-nhs commented 3 years ago

@Mohmedvaid Tests pass and cover your exact use case in #23. If you approve of including the EDI file, then I will merge this and release a new version.

Keep in mind that you'll need to pass a new flag of mode='loose' when calling either X12Transaction.toObject or constructing X12TransactionMap directly.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication