aave / protocol-v2

Aave Protocol V2
https://aave.com
Other
668 stars 755 forks source link

Protocol 2.5 - Refactor the `ValidationLogic.calculateUserAccountData` and `AaveOracle` variable names #192

Open The-3D opened 3 years ago

The-3D commented 3 years ago

The calculateUserAccountData function in ValidationLogic refers as the total collateral and total debt as denominated in ETH but this isn't necessarily true, as potentially the protocol can use different currencies to denominate the account balances. Therefore a refactor to include a baseCurrency postfix is needed to have a more generalized implementation.

Similarly, the AaveOracle refers to WETH as base currency but that is not necessarily true (USD can be used). This also needs to be refactored.