search

abacusmodeling / ABACUS-orbitals

4 stars 6 forks source link

Avoid extracting element information from folder names #11

Open coderabbitai[bot] opened 1 month ago

coderabbitai[bot] commented 1 month ago

As discussed in PR #103 at this comment, it's not a good practice to extract element information from folder names. We should refactor the code to avoid this.\n\nRequested by @kirk0830.

kirk0830 commented 5 days ago

extracting information from the folder's name is stupid and less robust. In the future a fingerprint file will be used to identify the ABACUS job folder (due to there is developer still use the folder name to identify by eye). Presently the solution is not to hard-coding the folder name, but to use one function to care for the nomenclature. The function can provide a unified and stable, although temporary solution.

kirk0830 commented 5 days ago

@dyzheng could you close this issue? Temporarily it is solved.