don't use fancy quotes in the conf.py template

abakan-zz / ablog

ABlog for blogging with Sphinx

ablog.readthedocs.org

Other

122 stars 35 forks source link

don't use fancy quotes in the conf.py template #87

Open tiwo opened 7 years ago

tiwo commented 7 years ago

This is a three-character patch to partially fix #86 that prevented me from doing ablog build right after ablog start under Windows.

I'm still not quite sure what happened (When does Python assume a cp1252 encoding in the first place? If fancy quotes in a comment break the build, why are umlauts in blog_title working?) - but no matter what, I'm confident nobody is going to miss the fancy quotes.

tiwo commented 7 years ago

Travis CI fails

For Python 2.6 at pip install Sphinx because "ERROR: You need Python 2.7 or 3.3+ to install the typing package."
For Python 2.7, 3.4, 3.5 because of the unrelated #78.

rayalan commented 6 years ago

Thanks for the patch; I needed it for Sphinx 1.6.5/Python 3.6. Would be great to see this merged and released.

nabobalis commented 6 years ago

This has now been merged into here. Thank you for the PR!