search

abarichello / godot-ci

Docker image to export Godot Engine games. Templates for Gitlab CI and GitHub Actions to deploy to GitLab Pages/GitHub Pages/Itch.io.
https://hub.docker.com/r/barichello/godot-ci
MIT License
759 stars 133 forks source link

Fix 3.5.3 segfault when running CI #147

Open Razzlegames opened 3 months ago

Razzlegames commented 3 months ago

Fixes: https://github.com/abarichello/godot-ci/issues/121

I went off of tag: 3.5-stable but I'm unsure what branch to make this PR against, as no 3.5 branch exists?

Calinou commented 3 months ago

Looks good, the only thing I'm worried about is that I'm not sure if this repository is set up to publish parallel branches correctly. In short, we want to be able to keep publishing releases of both 3.x and 4.x. When a new 3.x release is published however, it should not be considered the latest and cause existing 4.x users to switch over to 3.x until a new 4.x release is made (if they don't pin the Docker image version).

cc @TheOrioli

TheOrioli commented 3 months ago

@Calinou I've looked through the workflows.

It seems that manual builds will not overwrite the latest tag, but the regular release builds will.

Which means in case of a 3.5.4 release, the latest will be overwritten by Godot 3 😟

https://github.com/abarichello/godot-ci/blob/bd9eea16d14bf71f5876b71b16955218df36266b/.github/workflows/release.yml#L38-L53

This best way to fix this might be with some reusable workflows that pass along an override_latest bool as an input, which is figured out by parsing the godot version string.

Razzlegames commented 3 months ago

Darn, I'm just surprised anyone uses latest for this context at all. I suppose latest is for running against Godot master branch etc.

Any suggested edits, I'm all for :) . If I have time I can play with this but I doubt I'd be allowed to test and validate the push automation.