abarichello / godot-ci

Docker image to export Godot Engine games. Templates for Gitlab CI and GitHub Actions to deploy to GitLab Pages/GitHub Pages/Itch.io.
https://hub.docker.com/r/barichello/godot-ci
MIT License
759 stars 133 forks source link

add wine, rcedit, update to focal #37

Closed monban closed 1 year ago

monban commented 4 years ago

This PR does the following:

Contributor Edit: Fixes https://github.com/aBARICHELLO/godot-ci/issues/21

monban commented 4 years ago

As per the conversation above, I've changed --quiet to --no-verbose. Also I'm wondering if it would be a good idea to document somewhere as to how to use rcedit? Here is roughly what I'm doing on github actions:

      - name: Setup
        run: |
          chown -R root:root $HOME
          mkdir -v -p ~/.local/share/godot/templates
          mv /root/.local/share/godot/templates/${GODOT_VERSION}.stable ~/.local/share/godot/templates/${GODOT_VERSION}.stable
      - name: Windows Desktop Build
        run: |
          mkdir -v -p $GITHUB_WORKSPACE/build/windows-desktop
          cd $GITHUB_WORKSPACE/src
          godot -v --export "Windows Desktop" $GITHUB_WORKSPACE/build/windows-desktop/$EXPORT_NAME.exe
      - name: Convert png to ico
        run: convert $GITHUB_WORKSPACE/src/assets/common/textures/icons/icon.png -define icon:auto-resize="256,128,96,64,48,32,16" ~/icon.ico
      - name: Change exe icon
        run: cd $GITHUB_WORKSPACE; wine $GITHUB_WORKSPACE/rcedit.exe $GITHUB_WORKSPACE/build/windows-desktop/$EXPORT_NAME.exe --set-icon ~/icon.ico

In any event, please re-review and let me know if I can help by touching up the documentation anywhere.

realkotob commented 4 years ago

@monban If you'd like you can add a note at the bottom of README on how to use it, and/or a comment to the gitlab and github config scripts.

abarichello commented 4 years ago

Pipelines are working https://gitlab.com/BARICHELLO/godot-ci/-/pipelines/207459332

abarichello commented 4 years ago

Using wine for the rcedit with GitHub actions is failing with this error message: wine: '/__w/godot-ci/godot-ci' is not owned by you, refusing to create a configuration directory there Action log: https://github.com/aBARICHELLO/godot-ci/runs/1371907817?check_suite_focus=true

Also act is giving me different results locally, testing this is a real pain.

monban commented 4 years ago

Yeah, unfortunately you need to chown the home directory when running from GithubActions, here is an example of usage, (note the chown on line 30) I've been trying to figure out if there is a better way to accomplish this, hence why I haven't created the above referenced documentation yet...

2shady4u commented 3 years ago

@monban do you have any updates on this?

monban commented 3 years ago

You know what, I completely forgot about this, I'm sorry. I'll get on this after work today, expect an update in the next couple of hours.

Deozaan commented 3 years ago

This looks really useful. Is there any chance of this getting updated and merged? @monban

realkotob commented 1 year ago

@Deozaan If you are interesting in picking this up feel free to open a new PR with the changes.

Deozaan commented 1 year ago

If you are interesting in picking this up feel free to open a new PR with the changes.

I've looked into it briefly and I think it's beyond my skill level. 😳😬

monban commented 1 year ago

At this point I no longer recommend people to use rcedit, but rather to use Godot Icon instead.

Calinou commented 4 months ago