abarichello / godot-ci

Docker image to export Godot Engine games. Templates for Gitlab CI and GitHub Actions to deploy to GitLab Pages/GitHub Pages/Itch.io.
https://hub.docker.com/r/barichello/godot-ci
MIT License
759 stars 133 forks source link

Use GitHub CLI to fetch release information #92

Closed TheOrioli closed 2 years ago

TheOrioli commented 2 years ago

Fixes #91

The root cause of the issue was in the fact that GitHub actions doesn't respect shell scripting conventions, but instead replaces ${{ whatever }} by injecting the value of the variable directly into their generated script.

This created an issue where a single quote that is used by the workflow to ensure json doesn't get messed up got completed by a single quote in the release description, which in turn created an invalid bash script that the workflow tried to execute.

Instead of prefetching the release information, the workflow now fetches the body and tag name when necessary, using shell scripting the entire way, avoiding action executor weirdness.

Once merged, everything should run normally at 23:27