search

abartov / bybeconv

Project Ben-Yehuda's content management system.
https://benyehuda.org/
Other
10 stars 5 forks source link

Refactor involved_authorities editing UI for easier reuse in Collection #416

Closed damisul closed 5 days ago

damisul commented 3 months ago

Currently we can only edit involved authorities on Work and Expression level from /manifestations/edit_metadata form: изображение

I'd like to reuse this UI in Collection CRUD form (see https://github.com/abartov/bybeconv/issues/409) The problem is that old implementation is tied to manifestation editing form.

So I'd like to extract this and modify in more resuable form (move creation of InvolvedAuthorities from Manifestation#update action to InvolvedAuthorities controller and make it more flexible) so it will change manifestations/edit_metadata page as well.

P.S. Frankly speaking I'd like to use React to achieve this. I believe it could be a good demonstation on how React allows to simplify UI code and create reusable components. But for now I can do it with plain js/jQuery.

damisul commented 3 months ago

I also propose to use autocomplete field to fetch authorities (currently it loads whole array of authorities into a drop-down)

abartov commented 3 months ago

Yes, this is a good idea. Please do refactor. And yes, autocomplete (also querying the aliases in the additional names field!) would make sense at this point, instead of loading the whole table.

I am hesitant to add React to the project with the limited funding we have for your time. I would welcome revisiting that decision when we secure a larger grant that would enable more sustained work, including on infrastructure.