abcminiuser / python-elgato-streamdeck

Python library to control the Elgato Stream Deck.
Other
919 stars 137 forks source link

Add streamdeckplus support #127

Closed admiral0 closed 1 year ago

admiral0 commented 1 year ago

I cleaned up @karstlok 's pull request ( #108) to add support for the streamdeck+. Differences:

# no change
def callback_key(deck_instance, key_index, key_state_bool):
  pass
# changed
def callback_dial(deck_instance, dial_index, event_type: DialEventType, value):
  pass
# changed
def callback_touchscreen(deck_instance, event_type: TouchscreenEventType, value: dict):
  pass
benedikt-bartscher commented 1 year ago

Hi @admiral0 i just tested this PR with src/example_plus.py and as far as i can tell everything works fine. Thank you very much!

abcminiuser commented 1 year ago

Thanks! I meant to get to this sooner, but I've merged a slightly tweaked version of this in 56f91960297f753acdaeb79fd460c4326f7c4840.

Unfortunately the StreamDeck + is damned expensive in Australia (and I can't justify the expense for a hobby project) and Corsair told me to shove it when I asked for even temporary access to a unit, so I'm trusting on you and the rest of the community to verify that it works before I tag off the next version for PyPi.

Can you please grab the latest master and verify the example script works on the StreamDeck +?

admiral0 commented 1 year ago

I cannot test it for two weeks - traveling atm. Maybe @benedikt-bartscher or @joelspiers15 can.

karstlok commented 1 year ago

Just tested it, works.

benedikt-bartscher commented 1 year ago

Thanks @abcminiuser, i just tested the master branch, however the icons on the touchscreen are broken for me. They work fine in this MR. I will try to debug further later this evening.

benedikt-bartscher commented 1 year ago

I fixed those issues in https://github.com/abcminiuser/python-elgato-streamdeck/pull/129

joelspiers15 commented 1 year ago

Also was seeing that same touchscreen image drawing issue, #129 fixed it.