search

abdeladim-s / subsai

🎞️ Subtitles generation tool (Web-UI + CLI + Python package) powered by OpenAI's Whisper and its variants 🎞️
https://abdeladim-s.github.io/subsai/
GNU General Public License v3.0
1.32k stars 108 forks source link

Fixed double depedency on openai whisper #3

Closed jlinkels closed 1 year ago

jlinkels commented 1 year ago

When installing I get this error message:

The conflict is caused by:
    subsai 1.0.0 depends on openai-whisper<20230125 and >=20230124
    whisper-timestamped 1.11.0 depends on openai-whisper 20230306 (from git+https://github.com/openai/whisper.git@main#egg=openai-whisper)

So subsai requires openai-whisper. But subsai also depends on whisper-timestamped which in turn also depends on openai-whisper

Since openai-whisper is already pulled in by whisper-timestamped I think it is safe to remove the dependency.

jlinkels commented 1 year ago

Using the CLI throws an error when no -mc or --model-configs parameter is passed. The default value for model_configs_arg when no parameter is passed is {}. In function _handle_model_configs the method endswith is not defined.

abdeladim-s commented 1 year ago

The changes are merged successfully. Thank you @jlinkels for your contribution.