[Bugfix] Animate progress bar on mount, update demo

abdennour / react-progressbar

Basic progress bar in React.js

http://abdennour.github.io/react-progressbar/

MIT License

88 stars 28 forks source link

[Bugfix] Animate progress bar on mount, update demo #21

Closed lsanwick closed 3 years ago

lsanwick commented 6 years ago

Builds on top of #21

The progress bar would not animate on the initial mount of the component because no CSS transition would occur (the bar starts at the specified width). This adds handling to start the bar at 0 and transition to the passed in completed value.

I've also updated the code for the demo to work correctly and added a script to build the demo, build-demo. I don't know how this gets published to GitHub Pages, but that would need to be done after rebuilding the demo code.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 1c747e4423eca7e763a9d05d8fe5bae85d10e632 on lsanwick:ls/animation-fix into 4d6928a12a0d8f0dd2c61286f1a94fcfbc6c94a6 on abdennour:master.

lsanwick commented 6 years ago

@abdennour any chance you can review this?

abdennour commented 6 years ago

Hello @lsanwick sorry for the delay in getting back to you

lsanwick commented 5 years ago

No worries, thanks for taking a look!

lsanwick commented 4 years ago

@abdennour Can you look at this now? I've rebased it against the current master branch. Not sure how the demo gets published, so that build product might need to be ignored.