Angular 9 Support - Githubissues

Derenge commented 4 years ago

I recently downloaded this project to use in an Angular 9 app and ran into compatibility issues.

I've used the angular guide for creating libraries to create a new workspace and library. Simply copying over the src of this repository and updating the auto generated package.json got things working.

{
  "name": "ngrx-json-api",
  "version": "0.0.1",
  "peerDependencies": {
    "@angular/common": "^9.1.1",
    "@angular/core": "^9.1.1",
    "@ngrx/effects": "^9.1.0",
    "@ngrx/store": "^9.1.0",
    "rxjs-compat": "^6.5.5",
    "tslib": "^1.10.0"
  }
}

Are there plans to update this library to support Angular 9? I'm willing to investigate what changes would be necessary in this repository instead of forking.

I've only done a basic test of the functionality, but it seems to do exactly what I need. Great work by all involved!

morvans commented 4 years ago

I just pushed a 9.0.x branch in order to better align with Angular 9 & ngrx 9 and release a compatible version. I think we'd better adopt a versionning scheme that follow theses two from now on. @abdulhaq-e, thoughts ?

abdulhaq-e commented 4 years ago

@morvans I really need to sort out my github notifications, with so many notifications arriving I miss direct mentions like this.

I haven't used this lib (or Angular) for a long time now so my information is a bit rusty.

But yeah creating version that follow Angular and ngrx sounds good. If you can create an account on npm I can add you as a collaborator so that you can publish new releases directly.

morvans commented 4 years ago

@abdulhaq-e you can grant access to morvans NPM user.

abdulhaq-e commented 4 years ago

@morvans added.

abdulhaq-e / ngrx-json-api

Angular 9 Support #304