search

abernix / meteord

MeteorD - Docker Runtime for Meteor Apps for Production Deployments
https://registry.hub.docker.com/u/meteorhacks/meteord/
MIT License
93 stars 129 forks source link

CircleCI 2.0 and Node.js 8.12.0 #41

Closed KoenLav closed 5 years ago

KoenLav commented 6 years ago

Plus some minor tweaks here and there.

abernix commented 5 years ago

I hadn't actually noticed this PR when I quickly released Node.js 8.14.0 as a security update, but luckily, CircleCI 1.0 still ran for me despite the fact that they've supposedly "shut it down". (Neat, by accident.)

I really appreciate you working on this. I've included the net result of your PR in https://github.com/abernix/meteord/commit/2ac1d72b65e40f9feb22c72528ce0648573f5e86, which I just used to RE-publish the 8.14.0 image.

Ultimately, thank you so much for the CircleCI 2.0 aspect of this. I was very much not looking forward to making that move and CircleCI's own migration script failed me already.

I'll close this, since I think I've accomplished its intent, but thanks again and let me know if you have any problems with it! (The outstanding question is about PhantomJS, but I think we can continue to discuss that here as necessary.)

KoenLav commented 5 years ago

Thanks!