search

abernix / meteord

MeteorD - Docker Runtime for Meteor Apps for Production Deployments
https://registry.hub.docker.com/u/meteorhacks/meteord/
MIT License
93 stars 129 forks source link

Node 12.18.4 #55

Closed emjimadhu closed 3 years ago

emjimadhu commented 4 years ago

This PR has following

Meteor 1.11.1 Node 12.18.4

you can use the Docker image from here https://hub.docker.com/repository/docker/emjimadhu/meteord

maxfi commented 4 years ago

@emjimadhu Now that Meteor v1.11.1 has been updated to use node to v12.18.4 maybe this can be updated in your PR? Thanks!

emjimadhu commented 4 years ago

@emjimadhu Now that Meteor v1.11.1 has been updated to use node to v12.18.4 maybe this can be updated in your PR? Thanks!

Done! this PR is update for Meteor 1.11.1 and Node 12.18.4 and the Docker images are also updated. Thanks

maxfi commented 4 years ago

Any chance we could get this merged @abernix and pushed to Docker Hub? Would be really helpful for people using https://github.com/zodern/meteor-up. Realise you're probably super busy so thanks heaps in advance! 🙏 🙏 🙏

eugle commented 4 years ago

It feels like the author gave up

mtwalsh commented 3 years ago

Still early days in my testing but this image (zodern/meteor) seems to be working fine so far with Meteor 1.12 and it automatically uses the correct Node.js and npm versions:

https://github.com/zodern/meteor-docker

abernix commented 3 years ago

I've published new images with Node.js 12.20.0 and Meteor 1.12.

wvanooijen92 commented 3 years ago

@abernix Thank you! But I am a bit confused. It seems like meteor's node version is v12.18.4 for meteor v1.12 and v12.20.1 for meteor v1.12.1

$ meteor --version
Meteor 1.12

$ meteor node -v
v12.18.4
$ meteor --version
Meteor 1.12.1

$ meteor node -v
v12.20.1

With 12.20.0 I am unable to deploy. I get a "invalid ELF header" error, also described here https://github.com/veliovgroup/Meteor-Files/issues/781

I may be mistaken but to be able to test v12.18.4 and 12.20.1 would be great.