abess-team / abess

Fast Best-Subset Selection Library
https://abess.readthedocs.io/
Other
474 stars 41 forks source link

Disable normalization for GLM by default #488

Closed oooo26 closed 1 year ago

oooo26 commented 1 year ago

Since scikit-learn has deprecated normalize in estimators from version 1.0 and turned to use StandardScaler, we may also disable normalization by default.

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.85% // Head: 94.85% // No change to project coverage :thumbsup:

Coverage data is based on head (fb530f7) compared to base (c0badb5). Patch has no changes to coverable lines.

:exclamation: Current head fb530f7 differs from pull request most recent head d541167. Consider uploading reports for the commit d541167 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #488 +/- ## ======================================= Coverage 94.85% 94.85% ======================================= Files 27 27 Lines 2995 2995 ======================================= Hits 2841 2841 Misses 154 154 ``` | Flag | Coverage Δ | | |---|---|---| | Python | `97.72% <ø> (ø)` | | | rpackage | `93.48% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/abess-team/abess/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team) | Coverage Δ | | |---|---|---| | [python/abess/bess\_base.py](https://codecov.io/gh/abess-team/abess/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-cHl0aG9uL2FiZXNzL2Jlc3NfYmFzZS5weQ==) | `98.87% <ø> (ø)` | | | [python/abess/decomposition.py](https://codecov.io/gh/abess-team/abess/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-cHl0aG9uL2FiZXNzL2RlY29tcG9zaXRpb24ucHk=) | `94.56% <ø> (ø)` | | | [python/abess/linear.py](https://codecov.io/gh/abess-team/abess/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team#diff-cHl0aG9uL2FiZXNzL2xpbmVhci5weQ==) | `99.11% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=abess-team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.