Closed oooo26 closed 1 year ago
Cox and Ordinal is not supported because:
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
485255f
) 97.72% compared to head (19aacef
) 97.73%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I just have one more question:
abess
can correctly select the effective variables in this case? I just have one more question:
- Does
abess
can correctly select the effective variables in this case?
I have tested the examples in pytest, and they work just like the model with intercept, even when the data is not centered.
Only Gamma Regression performs not good, and I would test it on the centered data later.
Do u think we should do more simulated data tests to compare the performance?
That's pretty good. Gamma regression is much more difficult. Maybe the data generation mechanism is the main issue (see https://github.com/abess-team/abess/issues/509), we can address this later.
R API has been updated in 96ed869f48a0ba954b1ef101616dbf12ae7cbd3a.
As issuse #507 and #511 mentioned, we may introduce argument to control whether the intercept is considered or not. If the intercept is dropped, we would assume that the data has been centered.
LinearRegression
,LogisticRegression
,PoissonRegression
,MultiTaskRegression
,MultinomialRegression
andGammaRegression
when givenfit_intercept=False
;scikit-learn
's;