abhi11 / tanglu-dak

GNU General Public License v2.0
0 stars 2 forks source link

Does not process icons correctly #24

Closed ximion closed 9 years ago

ximion commented 9 years ago

The code should extract the 64x64 and 128x128 icons of a software (at least 64x64 should be available, the lowest acceptable size is 48x48). In the end, two tarballs should be generated, one with 64x64 icons, and one with 128x128 sized icons. Crrently, the code just extracts the first icon it finds, which is often the smallest size. It also doesn't rest the icons in icon-themes (/usr/share/icons//), which excludes many KDE applications from being shown (they have their icons stored in their own icon theme). On the client, all of that data is needed to build an icon cache as described at http://www.freedesktop.org/software/appstream/docs/sect-AppStream-IconCache.html

ximion commented 9 years ago

This issue is fixed by https://github.com/abhi11/tanglu-dak/commit/eeda99706125054661c3b05cb8329832b4a7227f and https://github.com/abhi11/tanglu-dak/commit/eeda99706125054661c3b05cb8329832b4a7227f The code will need some improvements though, it's not yet good enough (e.g. static size definitions should be config options and shared globally).