search

abhi11 / tanglu-dak

GNU General Public License v2.0
0 stars 2 forks source link

SVG sized rendering does not work #31

Open ximion opened 9 years ago

ximion commented 9 years ago

Rendered SVG icons do have the right size, but the actual icon is not scaled to the frma size. This gives odd results as seen in the attached screenshot. shot1

abhi11 commented 9 years ago

I am a bit confused on this one. Isn't it the client's task to see if the icon is scaled to the frame size. I mean, if the SVGs are rendered with correct size then the generators job is over right ? Onus lies on the client consuming the data(here the Icon). Am I wrong ?

ximion commented 9 years ago

Instead of explaining, here's one of the icons we generate - you'll easily see what's wrong ;-) laby_laby

abhi11 commented 9 years ago

Do you think using scale function here(https://github.com/abhi11/tanglu-dak/blob/master/dak/dep11/extractor.py#L191) would help ? This is kind of crazy I can't think of why it is happening. I'll push the anyways.

abhi11 commented 9 years ago

I have pushed it. But scaling paras should be 1x1 right ? I mean that's what I have done :-)

ximion commented 9 years ago

Let s see if it works - I will test it on Friday, I am super busy right now :-/