Closed sirdawidd closed 3 years ago
Do you have a fix for this?
I will merge it asap.
Also, try to create a sandbox with your issue for me to look into.
Fixed the case if subNav
is []
in v1.7.1
.
Also, for consistency, every click will call the callback method passed in props.
Other issues are also fixed as well from v.1.8.0
In case subNav is empty (And user selected on root element) <Navigation onSelect={({itemId}) => { will return itemId }}
In case subNav is not empty (And user selected on root element) <Navigation onSelect={({itemId}) => { will return not return anything }}
Which is a problem as in my case the Root menu elements render the page, where sub Nav items, are only used to scroll to position. Anyway when component sometimes return ItemId and in some conditions does not it's not consistent behavior of it.