search

abisee / cnn-dailymail

Code to obtain the CNN / Daily Mail dataset (non-anonymized) for summarization
MIT License
635 stars 306 forks source link

Could you make a branch for python3? #13

Closed becxer closed 7 years ago

becxer commented 7 years ago

Hello, I was impressed with your paper and code. Can I create a branch for Python 3? If it's not an excuse, I want to contribute to the conversion. Thanks.

JafferWilson commented 7 years ago

If you have Python3 version then you can please pull a request. I am sure the author of the repository will love to include it in. I am also looking for a Python3 version. It will be great if you can contribute.

becxer commented 7 years ago

I already converted to python3 on cnn-dailymail and pointer-generator but the branches what I can only pull-request are for master. It need to create other branch for python3 by author.

JafferWilson commented 7 years ago

Don't worry the author will verify it and will check what can be done.

abisee commented 7 years ago

Hi @becxer @JafferWilson

I don't plan to maintain a Python 3 version of this code, so I think it makes more sense for @becxer to have administrator privileges over the Python 3 version, not me. So how about I provide a link in the READMEs for both cnn-dailymail and pointer-generator to @becxer's forks?

https://github.com/becxer/cnn-dailymail https://github.com/becxer/pointer-generator/

becxer commented 7 years ago

It's okay to do that. Thank you for your reference.

abisee commented 7 years ago

OK, done.

JafferWilson commented 7 years ago

@becxer I guess this issue needs to be closed....