Fix unicode character printing

abishekvashok / cmatrix

Terminal based "The Matrix" like implementation

GNU General Public License v3.0

4.05k stars 423 forks source link

Closed patatahooligan closed 2 years ago

patatahooligan commented 4 years ago

EDIT: to clarify, this is concerning the -c option.

Fix several issues that prevented it from working

link to the wide-character version of ncurses
define NCURSES_WIDECHAR
use a function that can print wide characters
fix the character range. I don't know what the original was supposed to be, but half-width kana (which is what the movie reportedly used) was not at that range.

Tested this on arch linux with

It would be great if others could try it out on different setups so we can see how it works.

federicotorrielli commented 3 years ago

Maybe I'm missing some dependency but it won't compile. cmatrix.c:837: undefined reference to waddnwstr is the make error I'm currently seeing.

Running on Ubuntu 20.10

nixpulvis commented 3 years ago

Upon a quick inspection, this seems to be mostly working for me. Really dig'n the new look!

VeteraNovis commented 3 years ago

I'm having the same issue as federicotorrielli, running Ubuntu 20.04.

cmatrix.c:837: undefined reference to waddnwstr

Interestingly enough, line 837 is addwstr(char_array); and so I'm unsure why it thinks it is trying to call 'waddnwstr'

Dzoge commented 2 years ago

@patatahooligan can you please fix the conflicts so that the PR can be merged?

Dzoge commented 2 years ago

@abishekvashok can you please revisit this PR, since the conflict has been fixed?

abritinthebay commented 2 years ago

Any updates on this? Seems good to merge...