Closed maratal closed 4 months ago
In both ARTRealtimeChannelInternal and ARTRealtimePresenceInternal code in subscribeWithAttachCallback: is a dup of subscribe: with a nil event. Should be a single method called from another with parameter.
ARTRealtimeChannelInternal
ARTRealtimePresenceInternal
subscribeWithAttachCallback:
subscribe:
nil
I've noticed this when was implementing https://github.com/ably/ably-cocoa/pull/1942 which had two places where this should be done. So I decided to fix duplication first.
┆Issue is synchronized with this Jira Task by Unito
In both
ARTRealtimeChannelInternalandARTRealtimePresenceInternalcode insubscribeWithAttachCallback:is a dup ofsubscribe:with anilevent. Should be a single method called from another with parameter.I've noticed this when was implementing https://github.com/ably/ably-cocoa/pull/1942 which had two places where this should be done. So I decided to fix duplication first.
┆Issue is synchronized with this Jira Task by Unito