Support for http/socks proxy

aboutcode-org / vulnerablecode

A free and open vulnerabilities database and the packages they impact. And the tools to aggregate and correlate these vulnerabilities. Sponsored by NLnet https://nlnet.nl/project/vulnerabilitydatabase/ for https://www.aboutcode.org/ Chat at https://gitter.im/aboutcode-org/vulnerablecode Docs at https://vulnerablecode.readthedocs.org/

https://public.vulnerablecode.io

Apache License 2.0

523 stars 193 forks source link

Support for http/socks proxy #559

Open Hritik14 opened 3 years ago

Hritik14 commented 3 years ago

Currently we do not exclusively support http proxy because of using svn to fetch git tags. Though, it is possible to configure the svn binary to use proxied settings, it is not the best approach.

Possible fixes:

Ship with a local svn binary and allow explicit http_proxy in the config file (.env) and use it project wide
Somehow use both svn and github api to fetch the tags in suitable situations
Implement basic svn client protocol in python
??

pombredanne commented 2 years ago

I think we should stop using SVN for git tags and always require an API token for GitHub access... otherwise things are really unstable at times.

pombredanne commented 2 years ago

We may need still to have proxy support irrespective of using SVN. @tardyp I recall that's something that was a need for you... do you think we are all good otherwise?

tardyp commented 2 years ago

hi @pombredanne we have now deployed vulnerablecode in our intranet, and I think we upstreamed all of our fixes.

We'll do a rebase shortly and make sure of it.