search

abromberg / sentiment_analysis_python

Working with sentiment analysis in Python.
http://andybromberg.com/sentiment-analysis-python
212 stars 137 forks source link

Selecting features from all the data (both train and text data) #2

Open alenrooni opened 10 years ago

alenrooni commented 10 years ago

Hi, I ran your program and found something that you may want to work on it ;) when you are selecting the best features you should not look into your test data. It will look like your program is cheating :D I did the same mistake once and i was very happy that my small program is beating all state of the art classification algorithms of the world.

Good Program though.

abromberg commented 10 years ago

Great point @alenrooni ! If you want to fix it, I'd be more than happy to merge a PR in.