absinthe-graphql / absinthe

The GraphQL toolkit for Elixir
http://absinthe-graphql.org
Other
4.29k stars 527 forks source link

add telemetry phase when subscription config errors #1321

Closed michaelcaterisano closed 5 months ago

michaelcaterisano commented 5 months ago

What

Ensuring that telemetry events are fired when subscription config returns an error

Why

We would like to be able to hook into these events even when subscription config returns an error.

Testing

Wrote a new test to check that this functionality works. I'd also note that there are three failing tests on main that are unrelated to this change.