search

absinthe-graphql / absinthe

The GraphQL toolkit for Elixir
http://absinthe-graphql.org
Other
4.29k stars 527 forks source link

Check absinthe dependent libraries on CI runs #1322

Closed bryanjos closed 5 months ago

bryanjos commented 5 months ago

This PR adds a GitHub action to check the libraries that depend on Absinthe to ensure they still work with the changes added in PRs.

benwilson512 commented 5 months ago

Oh this reminds me, we should update the Elixir versions we test against, particularly with 1.17 out. We should only do 1.15, 1.16, and 1.17

maartenvanvliet commented 5 months ago

Is it failing because of the change/fix in the String.jaro_distance/2 in Elixir? https://github.com/elixir-lang/elixir/pull/13369

bryanjos commented 5 months ago

@maartenvanvliet thanks for that! I've been trying to figure it out. Especially since it passes locally with Elixir 1.17 and OTP 27, though I'm on a mac. I'll look and see if that's the issue.

bryanjos commented 5 months ago

I guess I wasn't running those versions locally after all. Updating, I can now see the failed tests locally. I'll see if I should update the test or the jaro distance threshold.

bryanjos commented 5 months ago

@benwilson512 I think this is good to go now! Aside from the CI changes, I lowered the jaro_distance slightly (thanks again @maartenvanvliet!), and fixed an issue dialyzer found.

maartenvanvliet commented 5 months ago

@benwilson512 I think this is good to go now! Aside from the CI changes, I lowered the jaro_distance slightly (thanks again @maartenvanvliet!), and fixed an issue dialyzer found.

No problem, saw the CI error and vaguely recalled the change in elixir a few months back