search

absinthe-graphql / absinthe_plug

Plug support for Absinthe, the GraphQL toolkit for Elixir
https://hex.pm/packages/absinthe_plug
MIT License
261 stars 163 forks source link

Fix minor stuff (and add dialyxir to CI) #283

Closed paulo-ferraz-oliveira closed 1 year ago

paulo-ferraz-oliveira commented 1 year ago

The individual commits are presented in a way that their content should help with the review.

The Dialyzer issues we'll see are fixed by changes in another pull request (edit: ... which means I can pull that in once/if it's approved+merged+tag/released).

paulo-ferraz-oliveira commented 1 year ago

@benwilson512, is there a chance this gets reviewed? Thanks.

paulo-ferraz-oliveira commented 1 year ago

Ah, this still needs the absinthe tag/release to be effective (otherwise it won't fetch the new dep.).

benwilson512 commented 1 year ago

Got it. Let me get that out here shortly.

paulo-ferraz-oliveira commented 1 year ago

@benwilson512, anything I can do to help unblocked that release/tag? (we're so close 😄)

benwilson512 commented 1 year ago

v1.7.2 of Absinthe has been published.

paulo-ferraz-oliveira commented 1 year ago

Force pushed to resolve merge conflicts...

paulo-ferraz-oliveira commented 1 year ago

I'm gonna adapt this lib.s base versions (Elixir + Erlang) to what absinthe's using.

paulo-ferraz-oliveira commented 1 year ago

CI results at https://github.com/paulo-ferraz-oliveira/absinthe_plug/actions/runs/5426470445

Edit: and again here after some new warnings were issued.

benwilson512 commented 1 year ago

Thanks!