search

abstracta / jmeter-java-dsl

Simple JMeter performance tests API
https://abstracta.github.io/jmeter-java-dsl/
Apache License 2.0
477 stars 59 forks source link

Refactor: Conditional to polymorphism #243

Closed Kabilesh020799 closed 1 year ago

Kabilesh020799 commented 1 year ago

I found a code smell that had multiple conditions in if and refactored it using polymorphism which improved the code quality. I would request you to merge this pr if you find this useful and makes sense. Thanks

rabelenda commented 1 year ago

Hello, thank you very much for reviewing the code and taking the time to submit a PR.

In this case though I think that the refactoring doesn't solve the issue of having multiple ifs and requires more code, making the code a little more complex/harder to maintain. So I will reject this PR.

I really appreciate that you sent the PR and are interested on finding ways to improve the code and tool. Thank you and keep looking for places to improve!