Refactor - Pullup variable

abstracta / jmeter-java-dsl

Simple JMeter performance tests API

https://abstracta.github.io/jmeter-java-dsl/

Apache License 2.0

477 stars 59 forks source link

Refactor - Pullup variable #244

Closed Kabilesh020799 closed 1 year ago

Kabilesh020799 commented 1 year ago

I have refactored the constant variable by pulling it up to the parent class. I kindly request you to merge this pr if this makes sense. Thanks

rabelenda commented 1 year ago

Hello, thank you again for taking the time to review the code and submit a PR!

I have added some comments in the PR, please review them and let me know.

One comment in general for the PR: this PR contains more changes than described in the PR comment. One option, to avoid surprises, is to describe every change in PR. A better option though would be to separate the changes in different PRs.

Regards