C++0x support not detected properly on MSVC 17

abumq / easyloggingpp

C++ logging library. It is powerful, supports asynchronous low latency, extendable, light-weight, fast performing, thread and type safe and consists of many built-in features. It provides ability to write logs in your own customized format. It also provide support for logging your classes, third-party libraries, STL and third-party containers etc.

MIT License

3.8k stars 929 forks source link

C++0x support not detected properly on MSVC 17 #282

Open seccalbr opened 9 years ago

seccalbr commented 9 years ago

The C++0x support is not detected properly due to the changes in the commit e8df64b. The _MSC_VER is defined as 1700 but it never defines the ELPP_CXX11.

// Visual C++
#define ELPP_COMPILER_MSVC (defined(_MSC_VER))
#define ELPP_CRT_DBG_WARNINGS ELPP_COMPILER_MSVC
#if ELPP_COMPILER_MSVC
#   if (_MSC_VER == 1600)
#      define ELPP_CXX0X 1
#   elif(_MSC_VER >= 1700)
#      define ELPP_CXX11 1
#   endif  // (_MSC_VER == 1600)
#endif  // ELPP_COMPILER_MSVC

abumq commented 9 years ago

Closed by https://github.com/easylogging/easyloggingpp/pull/330/commits (will close when code is released)