abynim / sketch-selective-upload

Exclude Artboards and Pages when uploading your Document to Sketch Cloud
19 stars 1 forks source link

Symbol Overrides being reset in upload? #11

Closed RussellBishop closed 3 years ago

RussellBishop commented 4 years ago

I've just been sending some angry emails to Sketch about Sketch Cloud, basically saying that overrides on nested symbols aren't making their way onto Sketch Cloud.

The response I received was that it may be caused by a plugin and that I should test this.

I've started doing some testing and I think I may have found that Selective Upload is part of the problem here. I'll continue to look into it – but do you think this could be possible @abynim ?

RussellBishop commented 4 years ago

If it helps, the document I think I'm finding this issue in is a Cloud Document, so every time I save it does a new Selective Upload to sketch.cloud.

RussellBishop commented 3 years ago

For clarity here, I made a stupid error. I was using a Sketch Cloud document (using Sketch Teams), and had rolled back to a previous version.

Obviously, this version was a Selective Upload, which lost my whole Symbols page which broke all instances.

Really - the lesson here is DO NOT use Selective Upload if your original file is not backed up somewhere other than Sketch Cloud.

abynim commented 3 years ago

Thanks for the follow up. I've added a warning in the readme to mention the lesson from this experience 🙌