Closed nitro56565 closed 4 months ago
Name | Link |
---|---|
Latest commit | fbcb79bdae5617182c1cce49afc63065a55975a8 |
Latest deploy log | https://app.netlify.com/sites/ap-template-playground/deploys/669a565e0a28ad0008a1f9b4 |
Deploy Preview | https://deploy-preview-86--ap-template-playground.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hi @Vinyl-Davyl can you please review the code
Hi @Vinyl-Davyl can you please review the code
Hi @nitro56565 looks great. Can you ensure you sign the DCO Checks?
@Vinyl-Davyl done
@Vinyl-Davyl done
alright I'll check that
I have merged your pr for concerto editor please check and let me know if there is any issue.
@nitro56565 what is the concerto editor change about?
@sanketshevkar there was type declaration issue in concerto which I fixed because my build was failing, but @Vinyl-Davyl had already fixed it in his new PR therefore I matched his changes with mine to avoid merge conflict.
@sanketshevkar there was type declaration issue in concerto which I fixed because my build was failing, but @Vinyl-Davyl had already fixed it in his new PR therefore I matched his changes with mine to avoid merge conflict.
Are @Vinyl-Davyl changes already merged? If yes, you had to rebase to the main. We shouldn't be seeing the diff for ConcertoEditor
.
@sanketshevkar there was type declaration issue in concerto which I fixed because my build was failing, but @Vinyl-Davyl had already fixed it in his new PR therefore I matched his changes with mine to avoid merge conflict.
Are @Vinyl-Davyl changes already merged? If yes, you had to rebase to the main. We shouldn't be seeing the diff for
ConcertoEditor
.
His changes are not yet merged should I rebase it back to the last changes as it was? but it would create a build error will that be fine?
Hey @Vinyl-Davyl I have merged your PR which was just pushed on the main branch with mine the code looks fine at my end can you please review. @sanketshevkar
@sanketshevkar there was type declaration issue in concerto which I fixed because my build was failing, but @Vinyl-Davyl had already fixed it in his new PR therefore I matched his changes with mine to avoid merge conflict.
Are @Vinyl-Davyl changes already merged? If yes, you had to rebase to the main. We shouldn't be seeing the diff for
ConcertoEditor
.His changes are not yet merged should I rebase it back to the last changes as it was? but it would create a build error will that be fine?
Hi @nitro56565 the changes has been merged now. I think you should rebase to main / pull the latest changes to ensure sync and eliminate the blocker you have on build. Also you should scope the changes to the "Stretched Logo on Mobile and Safari" issue i.e the Navbar.tsx file alone now, then you should be good to go.
Closes #84 #82
Description
This pull request addresses issue #84 , which highlights the problem of the logo appearing stretched on mobile devices and in the Safari browser. The issue was caused by browser-defined CSS, which has now been fixed. The logo will maintain its aspect ratio and display correctly on all devices and browsers, including mobile devices and Safari.
Changes
Screenshots or Video
Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:branchname