accordproject / template-playground

Web Playground for TemplateMark templates
https://playground.accordproject.org
Apache License 2.0
18 stars 22 forks source link

tests: generated sharable links test & compress/decompress data #89

Closed Vinyl-Davyl closed 4 months ago

Vinyl-Davyl commented 4 months ago

Changes

Flags

Author Checklist

netlify[bot] commented 4 months ago

Deploy Preview for ap-template-playground ready!

Name Link
Latest commit 495ef048d4d613a2d95645cd13385813c160ff3e
Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/66a760391a27d60009bb9250
Deploy Preview https://deploy-preview-89--ap-template-playground.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Vinyl-Davyl commented 4 months ago

Can you please from where the older code changes are coming out here in the diff? I remember the editors folder and even other changes already merged in main.

Yeah everything is good! The only reason is because I made a rebase from the main, reason it inherited all the changes from the folder changes PR previously. For I have started working on this branch too before that. cc: the only major file change to notice here is the compression.test.tsx and the generateSharableLink.test.tsx in the test folder

mttrbrts commented 4 months ago

Still some oddness with the rebase. Although, I'm happy to merge to avoid delay tomorrow. Let's discuss git ops when we next speak

Vinyl-Davyl commented 4 months ago

Still some oddness with the rebase. Although, I'm happy to merge to avoid delay tomorrow. Let's discuss git ops when we next speak

Alright, Sure