search

accounts-js / accounts

Fullstack authentication and accounts-management for Javascript.
https://www.accountsjs.com/
MIT License
1.5k stars 141 forks source link

feat: graphql api with graphql-module v1 #1141

Closed pradel closed 2 years ago

pradel commented 3 years ago

Closes #1079

changeset-bot[bot] commented 3 years ago

⚠️ No Changeset found

Latest commit: 66cfae19d2435ef15e2bf43c2350771c27787505

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Akarshit commented 3 years ago

Please let me know if I can help in any way to move this forward.

loan-laux commented 3 years ago

Also interested to help if I can!

pradel commented 3 years ago

@Akarshit @loan-laux I am in the middle of a moving so won't have time to finish this pr, I just pushed the last commit I did some days ago but if one of you want to finish the migration feel free 🙏

loan-laux commented 3 years ago

Good luck with the move, @pradel!

darkbasic commented 3 years ago

I think I can help with this: I recently upgraded my projects to v1 and I also want to have a look at https://github.com/accounts-js/accounts/pull/1014 to see if I can make changes less drastic with v1. If we can manage to fix those fundamental issues I will also update https://github.com/accounts-js/accounts/pull/1003 to v5 and I will finally be able to switch to accounts-js. At that point I will finally be able to put more time into this and implement the missing graphql resolvers (some strategies used to work only with the rest transport).

pradel commented 3 years ago

@darkbasic this sounds fantastic, feel free to ping me on slack if you need anything!

loan-laux commented 3 years ago

Looks like @tedraykov has made his own PR for that: https://github.com/accounts-js/accounts/pull/1147. Super excited to have this merged!

pradel commented 2 years ago

Closing in favor of https://github.com/accounts-js/accounts/pull/1189