acdh-oeaw / vicav-vue3

Reimplementation of the VICAV Frontend based on Vue.js 3
https://vicav-vue.acdh-ch-dev.oeaw.ac.at
MIT License
0 stars 0 forks source link

Missing label in marker properties #175

Open katharinawuensche opened 1 month ago

katharinawuensche commented 1 month ago

Some features in the geojson data do not include a label entry in their properties dict, leading to an error in the geo-map component. Can the name field be used as a label in these cases?

ctot-nondef commented 1 month ago

this should be solved on the data level - @simar0at will check with the product owners

currently the label is used for sorting

kisram commented 1 week ago

@katharinawuensche could you give me an example feature where this is the case?

katharinawuensche commented 1 week ago

The Wibarab features look like this:

{
    "type": "Feature",
    "id": "geo:zintan+LBY-ZTN",
    "geometry": { "type": "Point", "coordinates": [12.252778, 31.931667] },
    "properties": {
      "ft_djim": {
        "ǧ → ž": {
          "examples": ["žəld"],
          "sources": {
            "caubet_2004_3508": {
              "decade_dc": { "1940s": "high" },
              "link": "http://zotero.org/groups/2165756/items/Z8BXD2S8",
              "short_cit": "Caubet2004e"
            }
          }
        }
      },      
      "name": "Zintan",
      "variety": "LBY-ZTN"
    }
  },

Whereas the features in Vicav have an additional label field that often seems to be the same as the name:

{
    "type": "Feature",
    "geometry": {
      "type": "Point",
      "coordinates": [35.06666666666667, 32.916666666666664]
    },
    "properties": {
      "type": "geo",
      "name": "Akko/Acre",
      "label": "Akko/Acre",
      "hitCount": 1,
      "textId": "profile_akkon_01",
      "targetType": "Profile"
    }
  }

This label is currently used for sorting markers in multiple projects which is why we would either need the corresponding property in our Wibarab data or agree to use the existing name property in the frontend if label is not available.

kisram commented 1 week ago

I think it's fine to use the name property if you only need it for sorting