acekyd / made-in-nigeria

Here is a curation of awesome tools built by Nigerians that can be used by anybody and from anywhere in the world.
https://madeinnigeria.dev
1.02k stars 403 forks source link

feat(ui): creators blog #265

Closed kaf-lamed-beyt closed 10 months ago

kaf-lamed-beyt commented 10 months ago

Hi @acekyd, when you're chanced, kindly review.

However, here's a short note on what this PR entails and the reason behind the changes I made.

what's left

addresses #263

codesandbox[bot] commented 10 months ago

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

acekyd commented 10 months ago

Oh this awesome! Thanks @kaf-lamed-beyt. Responses to your notes:

For the other things, we can continue to fix and update the experience as the project goes on.

A few things:

kaf-lamed-beyt commented 10 months ago

That's odd - I have 13.4.19 fixed on my local. No idea why it should default to 14+ for you. But that could also explain the import error.

That's weird. I'd try downgrading again to see if the issue persists. If it does, I'll revert to 14.0.0 if that sounds okay.

Thanks for catching the page load thing - might create another issue but is it possible to add a loader as the page seems to freeze for a second before switching with this implementation?

Oh yes, that is possible. For now, the loader could just be a spinner, yes?

The blog is meant to be under the /creators link and menu instead of having a blog path or menu of it's own.

Nice! So if I understand you correctly, the creators nav item is going to be a drop-down? Or the blog's path is just going to be a URL segment. Something like: "/localhost:3000/creators/blog/"?

And yes. the blog search doesn't work for now. I forgot to mention it. But, It'll go into the next set of commit(s).

acekyd commented 10 months ago

No I’m saying /blog should become /creators. There’d be no /blog path.

The blog feature is meant for the creators.

--

Best, Adewale Abati Web Engineer & Developer Advocate, adewaleabati.com https://www.adewaleabati.com/ @ace_kyd https://twitter.com/ace_kyd

On Wed, Jan 17, 2024 at 12:41 PM null (for now) @.***> wrote:

That's odd - I have 13.4.19 fixed on my local. No idea why it should default to 14+ for you. But that could also explain the import error.

That's weird. I'd try downgrading again to see if the issue persists. If it does, I'll revert to 14.0.0 if that sounds okay.

Thanks for catching the page load thing - might create another issue but is it possible to add a loader as the page seems to freeze for a second before switching with this implementation?

Oh yes, that is possible. For now, the loader could just be a spinner, yes?

The blog is meant to be under the /creators link and menu instead of having a blog path or menu of it's own.

Nice! So if I understand you correctly, the creators nav item is going to be a drop-down? Or the blog's path is just going to be a URL segment. Something like: "/localhost:3000/creators/blog/"?

And yes. the blog search doesn't work for now. I forgot to mention it. But, It'll go into the next set of commit(s).

— Reply to this email directly, view it on GitHub https://github.com/acekyd/made-in-nigeria/pull/265#issuecomment-1895636922, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6RNUTBTADEFHQP6BMQRD3YO62ILAVCNFSM6AAAAABB56D3SKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJVGYZTMOJSGI . You are receiving this because you were mentioned.Message ID: @.***>

kaf-lamed-beyt commented 10 months ago

Oh! Thanks. I understand now.

acekyd commented 10 months ago

Cool. Let me know when the change is live so I can merge! @kaf-lamed-beyt

kaf-lamed-beyt commented 10 months ago

Sure thing. I'll let you know.

kaf-lamed-beyt commented 10 months ago

Hi @acekyd

So, I've moved /blog to /creators and also included search. One other thing I did was to conditionally render the navbar search component only on pages that need it. So, the homepage, creators, and projects.

You can test the "load more articles" button too.

I tried to see if I could extend the search feature of the blog to the navbar component. But, it feels a little bit deeper than I thought. The search component needs different types of data — articles and projects — and it is a global component housed in the root layout.

Perhaps, when I'm able to sit down and properly think of the flow, I can come up with a solution. In the meantime, kindly review this. Thanks!

acekyd commented 10 months ago

Hey! I love this start - we might have to have two different search components - for projects and creators. But this is a great start and I'll be merging now. Thanks @kaf-lamed-beyt

kaf-lamed-beyt commented 10 months ago

Nice!! I'm glad it made sense.