acemod / ACE3

Open-source realism mod for Arma 3
https://ace3.acemod.org
Other
1k stars 736 forks source link

Destroy Entity keybind no longer works with ACE loaded. #10375

Closed Mike-MF closed 3 weeks ago

Mike-MF commented 3 weeks ago

Mods (complete and add to the following information):

Description: Cannot kill units via Zeus using the End key (Destroy Entity keybind). But you can kill vehicles with it. Tested it with vanilla and it works fine, tested with just CBA still fine.

Nothing pops in RPT about it.

Steps to reproduce:

  1. Open Zeus
  2. Place any unit
  3. Try to end

Expected behavior: Should kill people.

Where did the issue occur?

PabstMirror commented 3 weeks ago

It's medical_engine it gets a handleDamage with _this=[unit,"",1,<NULL-object>,"",-1,<NULL-object>,"",true,0]

I don't think anything has changed so this must be a 2.18 thing?

I guess we just manually handle this match context == 0 and _sel = "" and _damage = 1 and _ammo = "" unless this matches something else?

LinkIsGrim commented 3 weeks ago

sel == "" is the same as context == 0

damage == 1 and context == 0 can happen with vehicle hits but ammo should be passed along in that case

tl;dr should work, match context == 0, ammo == "", damage == 1, return damage?

edit: we might want to match the null shooter/instigator as well to be safe