achiurizo
commented
12 years ago Yeah there does need to be some additional work to fix issues like these. I've been meaning to do a rewrite of terminitor and break out some of the core specific code into its own gem and keep the main core lean with just the dsl and abstractions for the core. Once I get some time away from work, I'll start working on this. I'll update this ticket once I get around to that rewrite, until then, feel free to message me if I take too long :D
mcmire
kevzettler
The PS1 trick in AbstractCore#run_in_window does nothing in iTerm 2. The patch described in #63 would fix the issue (in both iTerm 1 and 2), but applying it directly is not the best solution. Ideally, setting PS1 should be abstracted away somehow so that iterm_core.rb can override it. #set_options would be the best place for this, as it already has the responsibility of taking the tab options and applying them to the tab. However that would work for iTerm but not for setting PS1, because it accepts an options hash and doesn't have access to the appscript tab object, so it can't write commands to the tab. So there's a bit of work that has to be done to fix this issue correctly.