search

aclemons / sbo-bot

MIT License
2 stars 0 forks source link

Different result on extracting tarball #784

Closed willysr closed 1 week ago

willysr commented 1 week ago

please take a look on gem submission on ARCHIVE I ran sbo-bot and it got pushed to https://github.com/SlackBuildsOrg/slackbuilds/pull/8742 it shows that no rc.gem exists, but when i look into the tarball in ARCHIVE, it does exists

willysr@home:~$ tar xvf /data/repo/sbo/ARCHIVE/gem.tar.gz 
gem/
gem/gem.info
gem/gem.8
gem/gem.SlackBuild
gem/doinst.sh
gem/README
gem/slack-desc
gem/rc.gem
aclemons commented 1 week ago

The sbo repo has a gitignore on all gem files (rubygems): https://github.com/SlackBuildsOrg/slackbuilds/blob/0068f2d957c654d284d3c95f1df237a72eb8a494/.gitignore#L14

So git add . does not add it:

https://github.com/aclemons/sbo-bot/blob/48014e38ddbe33015a174590815833f59283fd29/bin/generate-submission-prs.sh#L84

aclemons commented 1 week ago

We could change it to force add everything and ignore the gitignore. Then if there is some rubbish, we'd just need to update the PR while reviewing.

Should we make that change?

willysr commented 1 week ago

ah, didn't think of that i think i was the one who added that entry in gitignore since there's only 1 entry who had issue, i think we can change the name of the rc.gem into something else to avoid the .gitignore entry