acmucsd / membership-portal

REST API for the UC San Diego ACM chapter's membership portal.
https://members.acmucsd.com
Mozilla Public License 2.0
17 stars 5 forks source link

Update Deprecated CI Docker Images #420

Open nik-dange opened 8 months ago

nik-dange commented 8 months ago

Info

Partially closes #289

Description

The Docker images that we use on CircleCI are deprecated, and we should switch to their next-gen images. More info here: https://circleci.com/docs/next-gen-migration-guide/, but this change should be more reliable/maintained/ideally speed up deployment times.

Changes

Type of Change

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

Checklist

Screenshots

Please include a screenshot of your Postman testing passing successfully.

github-actions[bot] commented 8 months ago

Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see this guide to semantic versioning for details—and document those changes as appropriate.

nik-dange commented 8 months ago

I was able to find a matching next-gen image for our Node v14.17.6 ones from here (https://circleci.com/developer/images/image/cimg/node), but I was unable to find a 1:1 match for our Postgres image (which uses v11.5), see https://circleci.com/developer/images/image/cimg/postgres. Thoughts on moving forward from this? Using the closest minor version vs. overall upgrading our Postgres version? Would need to look into going about the latter but it might not be a bad idea