acmucsd / membership-portal

REST API for the UC San Diego ACM chapter's membership portal.
https://members.acmucsd.com
Mozilla Public License 2.0
17 stars 5 forks source link

Updating Mapping of Public/Private types to API Layer #450

Closed jennymar closed 1 month ago

jennymar commented 1 month ago

Info

Closes #326

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant motivation or context.

Changes were made to almost all the controller classes in the API layer, as well as their corresponding service classes in the service layer. The mapping of private to public types was moved from the service layer to the API layer.

Changes

API Layer

Service Layer

Type of Change

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

Checklist

Screenshots

Please include a screenshot of your Postman testing passing successfully.

github-actions[bot] commented 1 month ago

Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see this guide to semantic versioning for details—and document those changes as appropriate.