Switching to normal mode (vi keys) modifies $status and $pipestatus

acomagu / fish-async-prompt

Make your prompt asynchronous to improve the reactivity.

MIT License

389 stars 22 forks source link

Switching to normal mode (vi keys) modifies $status and $pipestatus #69

Closed dnnr closed 5 months ago

dnnr commented 10 months ago

When using fish's default prompt and vi-like keybindings, pressing Escape to enter the vi normal mode appears to inadvertently set $status and $pipestatus to 1.

This can be observed by the red [1] marker that gets added to the prompt right after pressing Escape.

Switching back to insert mode sets $status and $pipestatus back to their original values.

acomagu commented 5 months ago

@dnnr Hi, sorry for long inconvenience. I think that issue is resolved by 23e416f. Could you confirm it?

dnnr commented 5 months ago

No problem at all, thanks for working on it! Sadly, I can't confirm that the change fixes the issue. Instead of only getting the failure marker when switching to normal mode, it's permanently there now.

I was also able to reproduce the problem in a fresh debian:unstable docker container running fish 3.7.0. Let me know if there's anything else I can do to help zero in on the issue.