fix: address issue with computeclass tables not converting properly

tylerslaton commented 5 months ago

This fixes an issue where acorn offerings computeclasses and kubectl get clustercomputeclasses would fail with the following error:

  ✗  ERROR:  template: :1:39: executing "" at <memoryToRange .Memory>: error calling memoryToRange: object passed is not a ComputeClassMemory struct

This was due to a recent change where the Memory struct on apiv1.ComputeClass and adminv1.ClusterComputeClass are now different. The fix is to check for both types and process them accordingly when converting values into a table.

Checklist

[X] The title of this PR would make a good line in Acorn's Release Note's Changelog
[X] The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
[X] All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
[X] Commits follow contributing guidance
[X] Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
[X] Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
[ ] PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

cjellick commented 5 months ago

go ahead and merge. you addressed @Grant Linville's comment and he's getting lunch. donnie approved. im good with you merging it

tylerslaton commented 5 months ago

https://github.com/acorn-io/runtime/issues/2429

acorn-io / runtime

fix: address issue with computeclass tables not converting properly #2438

Checklist