Drush site aliases fail Drupal Coding standards

christopher-hopper commented 7 years ago

Motivation

It has bothered me for a long time that Drush aliases generated for Acquia Cloud do not pass Drupal coding standards checks. When added to a project the aliases.drushrc.php file causes automated phpcs checks to fail.

Steps to Replicate

Generate Drush site aliases for an Acquia Cloud site
Install and configure Drupal coder-8 with PHP Code Sniffer
Run Drupal coding standards checks over generated Drush site aliases file

Proposed Changes

Fix Drupal coding standards in Drush aliases template

Next Steps

Raise a ticket with Acquia Cloud directly, pointing to this issue as an example, to fix their aliases template used at this URL https://accounts.acquia.com/account/[:ACCOUNT-ID:]/security/drush_aliases/download.
Improve the code quality more generally in the generated Aliases file, for example:
- Clean-up or Remove the left-over, unnecessary, Global scope variables in the file (ie. $drush_version_components)
- Stop using the deprecated Drush site alias key parent.

kylebrowning commented 7 years ago

That is unrelated to this project and probably a ticket you should put on acquia.com

christopher-hopper commented 7 years ago

To be clear, you are doing it here too. Your site alias file is also not meeting the standards. Can we fix it?

kylebrowning commented 7 years ago

OH, in that case, yes.

christopher-hopper commented 7 years ago

If you have any contacts within Acquia Cloud who can point me at the code that generates their site aliases (which match yours EXACTLY), please pass them on.

Please review my Pull Request. I'd love to do the same for the Acquia Cloud people's template too.

christopher-hopper commented 7 years ago

I've raised a support issue with Acquia Cloud to replicate the changes we make here in their generated Acquia Cloud Drush site aliases.

for my own reference, ticket is linked below

https://insight.acquia.com/support/tickets/344723

I have referenced this issue and pull request #38 in that ticket.

christopher-hopper commented 7 years ago

:newspaper: Latest Update

Acquia Cloud support have responded and will be watching the progress of this issue before making changes to their source Drush site alias generation template. So the fixes we apply here will feed into what they may do.

Open source can save the day!

acquia / club