acquia / moonshot

Moonshot: Because releasing services shouldn't be a moonshot!
Apache License 2.0
53 stars 49 forks source link

Possibility of removing pinned activesupport version #198

Open janost opened 7 years ago

janost commented 7 years ago

Our project uses activerecord 5 and while upgrading to moonshot 1.1, we discovered that moonshot has pinned activesupport < 5.0.0 to retain compatibility with ruby < 2.2.2. Since activerecord 5 is depending on activesupport 5 that means our dependencies are colliding.

We'd like to propose to drop the pinned version of activesupport. Users running an older ruby version would still be able to pin activesupport if needed.

askreet commented 7 years ago

Maybe we can implement our own duration to string logic, since that's all we use ruby-duration for, which has the dependency on activesupport.

janost commented 7 years ago

It seems interactive-logger also depends on ruby-duration, so if we decide to go this way, we'll need to remove it from both projects.

This is no longer blocking our upgrade right now, because we need to stick to activerecord 4 for other reasons, but other users might be affected and we plan to upgrade to activerecord 5 in the future.