search

acquia / moonshot

Moonshot: Because releasing services shouldn't be a moonshot!
Apache License 2.0
53 stars 49 forks source link

Increase default Moonshot.config.changeset_wait_time? #227

Open geerlingguy opened 7 years ago

geerlingguy commented 7 years ago

I've been hit by this three times in the past few weeks—it seems sometimes AWS takes a little longer to compute the change set for some of my CF stacks, and when this happens, I get the message:

I, [2017-06-09T21:28:15.471941 #75]  INFO -- : Waiting for ChangeSet project-dev-cluster-1497043694 to be created.
ChangeSet did not complete creation within 90 seconds! (at /var/lib/gems/2.3.0/gems/moonshot-2.0.0.beta2/lib/moonshot/change_set.rb:96:in `block in wait_for_change_set')

(Even though only seconds later the change set is created and ready to execute—which I can then do via the AWS Console).

I would suggest maybe bumping this to 120, or maybe even a little more, in the case that Change Sets take a little longer to build (it seems to happen pretty randomly to me).

geerlingguy commented 7 years ago

As a workaround, you can configure the wait time separately in your Moonfile.rb:

Moonshot.config do |c|
  c.app_name = 'project'
  c.changeset_wait_time = 300
end

But it would be better to make sure that even slow change set builds pass by default.